Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement dependency checks inside webpack config #31

Open
davwheat opened this issue Oct 13, 2021 · 0 comments
Open

Implement dependency checks inside webpack config #31

davwheat opened this issue Oct 13, 2021 · 0 comments

Comments

@davwheat
Copy link
Member

As a result of our recent 1.1 release issues, it might be a good idea to introduce some way of validating that we are using the correct Webpack version.

We could do this by adding some code to attempt to read a package.json file and looking for a webpack key under dependencies/devDependencies. If we see a value >= 5.0.0 (semver) then we abort the build.

This would then mean our CI fails and we can check what went wrong, rather than it silently "failing" (incorrectly building for our needs) and us tagging broken releases.

@askvortsov1 askvortsov1 transferred this issue from flarum/framework Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant