Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user registration by admin #337

Closed
dcsjapan opened this issue Mar 20, 2016 · 17 comments
Closed

Allow user registration by admin #337

dcsjapan opened this issue Mar 20, 2016 · 17 comments

Comments

@dcsjapan
Copy link

This feature came in really handy when we set up our in-house esoTalk forums, which are invitation-only.

This can be added as part of a user list feature.

@ghost
Copy link

ghost commented Mar 21, 2016

+1 for this feature!

@SamuelHassine
Copy link

+1 !

@danechitoaie
Copy link

And also making sure that it can be configured so that guests won't see anything except the login form.

@dcsjapan
Copy link
Author

dcsjapan commented Apr 3, 2016

@danechitoaie That's already covered by the "Sign up" setting on the Permissions page.

Here's a picture of a test forum with registration closed. There's no "Sign Up" link.

no-reg

@danechitoaie
Copy link

The guests still see something. I'm looking at not allowing them to see anything but a single login page (i.e. user/pass fields and a submit button).

Maybe this can be achieved with an extension?

@dcsjapan
Copy link
Author

dcsjapan commented Apr 3, 2016

What exactly don't you want your guests to see? Have you tried changing the "View discussions" permission setting to "Members"? That would at least keep your content private.

If you don't want visitors to know there's a forum there, that's something Flarum isn't set up to do. Since the login form is a modal dialog, showing just the form would be hard to do without an extension.

... At any rate, your request doesn't really have much to do with the present issue, which is only about registration. I'll move your discussion in the forums to Feedback, where you may find someone whose interested in developing the extension you'd need.

@ghost
Copy link

ghost commented Jan 26, 2017

+1

@stale

This comment has been minimized.

@stale stale bot added the stale label Jan 19, 2020
@stale

This comment has been minimized.

@stale stale bot closed this as completed Feb 18, 2020
@franzliedke franzliedke reopened this Mar 13, 2020
@stale stale bot removed the stale label Mar 13, 2020
@clarkwinkelmann
Copy link
Member

I had never noticed this issue.

Right now the REST API already allows admins to register new users even when the forum is closed.

This extension adds a way to use that API while logged in https://github.com/clarkwinkelmann/flarum-ext-create-user-modal

@askvortsov1
Copy link
Member

This extension adds a way to use that API while logged in https://github.com/clarkwinkelmann/flarum-ext-create-user-modal

Issue is, I'm not sure if that will work for the new admin UI list since the signup modal component is in forum.

@davwheat
Copy link
Member

Can't we move it to common like we did with EditUserModal?

@askvortsov1
Copy link
Member

Can't we move it to common like we did with EditUserModal?

We could. With the code splitting stuff the effect would be minimal.

@clarkwinkelmann
Copy link
Member

If you don't add it in the user list in core, I can easily adapt my extension to also add the modal there. I see this was a milestone for later so my extension can take care of it in the meantime.

I'll probably need to update the extension to re-implement the modal from scratch instead of extending SignUpModal since SignUpModal won't be available from the admin. But that's not very complicated, since I'm essentially extending it to remove stuff, so that's even less to copy-paste.

If we add it in core I don't think we will extend the SignUpModal anyway, it makes more sense to create a new modal component for it anyway.

@davwheat
Copy link
Member

davwheat commented Apr 21, 2021

There isn't any easy way to extend the user list to add new items except in columns. We might want to add that...

@askvortsov1
Copy link
Member

askvortsov1 commented Apr 21, 2021

There isn't any easy way to extend the user list to add new items except in columns. We might want to add that...

Let's do so in a v2. For now we need to get user list merged, as there's still a fair bit left to do in the release.

@askvortsov1 askvortsov1 transferred this issue from flarum/framework Mar 10, 2022
@SychO9
Copy link
Member

SychO9 commented Sep 1, 2023

flarum/framework#3744

@SychO9 SychO9 closed this as completed Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants