Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make in-process rbuilder 1st class citizen #229

Open
liamaharon opened this issue Oct 28, 2024 · 0 comments
Open

Make in-process rbuilder 1st class citizen #229

liamaharon opened this issue Oct 28, 2024 · 0 comments

Comments

@liamaharon
Copy link
Contributor

liamaharon commented Oct 28, 2024

Problems:

  • We loose the ability to restrict reth process on the os level. (threading / io)
  • Its no longer clear how many threads do we have and how can we schedule our work more efficiently because we fight with the reth internal jobs.
  • Lifetime of builder process is now tied to reth. Right now builder often kills itself to clean up some weird state. Now this approach will be sub-optimal because stopping reth prevents it from syncing and clears mempool / peers.
  • Mempool can fall out of sync on node restart

We can do something about it though but it will require some work and change of internals. (e.g. watchdog instead of killing the process will restart builder inside reth). We can use our own threadpools and never touch global ones (rayon).

also need to get playground working with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant