You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a payload contains transactions then it should be propagated, even if its value is 0. Although this may not seem like a particularly useful result, it is still a valid one and sending it to the relay provides useful information and allows for special-case processing of the payload.
✅ I have completed the following steps:
Run make lint
seeing error error: failed to run custom build command for reth-mdbx-sys v1.0.6 (https://github.com/paradigmxyz/reth?tag=v1.0.6#c228fe15)
Run make test
seeing error error: failed to run custom build command for reth-mdbx-sys v1.0.6 (https://github.com/paradigmxyz/reth?tag=v1.0.6#c228fe15)
Added tests (if applicable)
There do not appear to be tests for this part of the codebase
@ferranbt pretty much as the description says: even if a payload has a nominal value of 0, if it contains transactions and is the highest value payload that can be built from the available transactions then it should be considered valid.
As to why 0 value transactions should be considered at all: not paying the (arbitrary) proposer any fees is a requirement for some transaction initiators, where they cannot make payments to the proposer without knowing who the are. The only real solution to this is to have a 0 tip for the transaction. And ultimately it is possible for a block to only consist of such transactions.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Allow payloads with transactions to propagate to relays, even if the payload value is 0.
Fixes #242
💡 Motivation and Context
If a payload contains transactions then it should be propagated, even if its value is 0. Although this may not seem like a particularly useful result, it is still a valid one and sending it to the relay provides useful information and allows for special-case processing of the payload.
✅ I have completed the following steps:
make linterror: failed to run custom build command for reth-mdbx-sys v1.0.6 (https://github.com/paradigmxyz/reth?tag=v1.0.6#c228fe15)make testerror: failed to run custom build command for reth-mdbx-sys v1.0.6 (https://github.com/paradigmxyz/reth?tag=v1.0.6#c228fe15)