Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flet if no dependencies provided for flet publish command #4508

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

FeodorFitsner
Copy link
Contributor

@FeodorFitsner FeodorFitsner commented Dec 6, 2024

Fix #4493

Summary by Sourcery

Bug Fixes:

  • Ensure the flet publish command includes flet as a dependency if no other dependencies are provided.

Copy link
Contributor

@ndonkoHenri ndonkoHenri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • What happens if len(dependencies) > 0 (other packages are specified) but Flet is forgotten/omitted? Should we have that considered too?

  • do we need such checks in build too?

@FeodorFitsner
Copy link
Contributor Author

What happens if len(dependencies) > 0 (other packages are specified) but Flet is forgotten/omitted? Should we have that considered too?

That's the whole fun. In pre-0.25 we were adding flet dependency here and there, but I realized that at some cases it could be indirect dependency, for example someawesome-flet-package could depend on flet and requirements.txt could have only someawesome-flet-package listed. I think we should assume the app has flet as dependency if requirements.txt is not empty 🤨

@ndonkoHenri
Copy link
Contributor

Yeah, makes sense!

@FeodorFitsner FeodorFitsner merged commit b190d0b into 0.25.2 Dec 10, 2024
1 of 3 checks passed
@FeodorFitsner FeodorFitsner deleted the feodor/fix-flet-publish-deps branch December 10, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants