Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using shadow DOM to prevent embedded re-frisk from affecting the app #78

Open
p-himik opened this issue Mar 10, 2023 · 1 comment
Open

Consider using shadow DOM to prevent embedded re-frisk from affecting the app #78

p-himik opened this issue Mar 10, 2023 · 1 comment

Comments

@p-himik
Copy link

p-himik commented Mar 10, 2023

Not sure whether you have considered it before, but FWIW that's how re-frame-10x does it.
@p-himik
Copy link
Author

p-himik commented Mar 10, 2023

Although now that I have tried it, it seems that the embedded route is even less viable. Re-frisk has dependencies that are commonly found in apps or other libraries, and those are not vendored in (how re-frame-10x also does). Might not be a problem in the majority of cases, but just now I got a warning from an older version of re-com that uses some deprecated functionality in a newer Reagent. Some other potential issues might be proper errors that would be hard to debug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@p-himik