Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up and improve CodeGeneratorImplTest #22

Open
coderabbitai bot opened this issue Jan 19, 2025 · 0 comments
Open

Clean up and improve CodeGeneratorImplTest #22

coderabbitai bot opened this issue Jan 19, 2025 · 0 comments

Comments

@coderabbitai
Copy link

coderabbitai bot commented Jan 19, 2025

Multiple improvements needed in CodeGeneratorImplTest:

  1. Clean up tests to handle dependent classes better
  2. Use equals of test class instead of manual comparison of members
  3. Fix test picking up jackson object mapper

File: pibify-maven-plugin/src/test/java/com/flipkart/pibify/codegen/CodeGeneratorImplTest.java

Related PR: #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant