Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match matchers on diffing messages #7

Open
dorner opened this issue Aug 9, 2019 · 0 comments
Open

Match matchers on diffing messages #7

dorner opened this issue Aug 9, 2019 · 0 comments
Labels
enhancement New feature or request high priority This should be one of the first things worked on.

Comments

@dorner
Copy link
Member

dorner commented Aug 9, 2019

Currently, Deimos::TestHelpers tries to be smart about reporting the diff between the closest message sent and the reported one. However, in its matching and reporting, it treats matchers as a value rather than something to match against a value - i.e. anything is always treated as different from the other hash rather than the same.

See if we can make this smarter so our error messages are more useful and there isn't a lot of noise about AnyArgMatcher being different from the given value.

@dorner dorner added the enhancement New feature or request label Aug 9, 2019
@dorner dorner added the high priority This should be one of the first things worked on. label Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high priority This should be one of the first things worked on.
Projects
None yet
Development

No branches or pull requests

1 participant