Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTTP status codes #9

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Use HTTP status codes #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion protoc-gen-rails/internal/output.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ class {{.ControllerName}}Controller < ActionController::Base
render json: GrpcRest.error_msg(e), status: :internal_server_error
end
rescue_from GRPC::BadStatus do |e|
render json: GrpcRest.error_msg(e), status: :internal_server_error
render json: GrpcRest.error_msg(e), status: GrpcRest.grpc_http_status(e.code)
end
rescue_from Google::Protobuf::TypeError do |e|
render json: GrpcRest.error_msg(e), status: :bad_request
Expand Down
2 changes: 1 addition & 1 deletion protoc-gen-rails/testdata/base/app/controllers/my_service_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class MyServiceController < ActionController::Base
render json: GrpcRest.error_msg(e), status: :internal_server_error
end
rescue_from GRPC::BadStatus do |e|
render json: GrpcRest.error_msg(e), status: :internal_server_error
render json: GrpcRest.error_msg(e), status: GrpcRest.grpc_http_status(e.code)
end
rescue_from Google::Protobuf::TypeError do |e|
render json: GrpcRest.error_msg(e), status: :bad_request
Expand Down
Loading