Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mistake found #5

Open
fangthu opened this issue Dec 6, 2016 · 0 comments
Open

mistake found #5

fangthu opened this issue Dec 6, 2016 · 0 comments

Comments

@fangthu
Copy link

fangthu commented Dec 6, 2016

hi, thank you for you job. It is very helpful and easy to understand!

But it seems there's a mistake in 'filter_env.py'

The line 'ac_f = np.clip(self.filter_action(action),self.action_space.low,self.action_space.high)'

All the actions are constrained to '-1 to 1' instead of the real inputs.

And another question is : have you ever used XX_bn as the networks ?

In my situation, the result is worse. I do not know it is normal of not .

Best

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant