Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect 'controlled vocabulary' loading code #77

Open
zhouji2013 opened this issue Oct 3, 2020 · 1 comment
Open

incorrect 'controlled vocabulary' loading code #77

zhouji2013 opened this issue Oct 3, 2020 · 1 comment
Assignees
Labels

Comments

@zhouji2013
Copy link
Member

The class ControlledVocabularyPerColumnWriter works correctly only when the write method is called once for all the controlled vocabulary items. This 'good' situation happens when the spring batch commit interval is set to be larger than the number of the items. The commit interval is set as a property of controlledVocabularySimpleStep in controlledVocabularyApplicationContext.xml. However, method write may be called multiple times, depending on the number of all the items and the setting of the commit interval, and is meant to do so. The consequence of the bug is currently just being avoided by using a large commit interval.

@zhouji2013 zhouji2013 added the bug label Oct 3, 2020
@zhouji2013 zhouji2013 self-assigned this Oct 3, 2020
@zhouji2013
Copy link
Member Author

The number of controlled vocabulary items in the latest data is 21,727. It is in fact the sum of the numbers of observed_subject_role, 3,395, and observed_evidence_role, 18,322. The other relevant numbers are: subject_role 5, evidence_role 4, and observation_template 689.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant