Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node groups/layers #43

Closed
bergie opened this issue Nov 5, 2013 · 5 comments
Closed

Node groups/layers #43

bergie opened this issue Nov 5, 2013 · 5 comments

Comments

@bergie
Copy link
Member

bergie commented Nov 5, 2013

For a better way of explaining the structure of a graph, we need to support something like node grouping/layering with some textual information added.

The groups could be possible to either hide completely ('show only the templating part of this graph'), or maybe showable as a single node, sort of as 'inline subgraphs'.

Originally opened as meemoo/dataflow#56, see that for older discussion. The NoFlo side of this ticket is noflo/noflo#62

UI mockups

Grouped nodes in a graph:

screenshot 2013-11-05 at 11 55 33

Group navigator card (which would be in noflo/noflo-ui):

screenshot 2013-11-05 at 11 52 00

@bergie
Copy link
Member Author

bergie commented Nov 5, 2013

Here is an example of layer controls in PhotoShop:

photoshop_layer

@alx359
Copy link

alx359 commented Nov 5, 2013

Technically, layers could be seen just as composite components, but that would be missing the point. I believe one needs to empower, especially FBP newcomers, with as many useful complementary views to a system as possible, to help fight "spagettification" and to enforce patterns/best practices not necessarily related to the execution flow.

Another complementary view to zoom in/out is the tree outline (the way chosen by Tersus to aid model navigation, btw).

tersus-tree

Edit:

  • Usability tip, for blending of layers and the tree outline. Whatever components we may see in a selected layer, they become bold (colored, etc) in the tree outline. And vice versa: whatever component we may choose in the tree outline, it makes the layer it resides selected.

@forresto
Copy link
Collaborator

forresto commented Jan 9, 2014

Basic groups working in http://forresto.github.io/prototyping/react/

screen shot 2014-01-09 at 7 48 09 pm

@bergie
Copy link
Member Author

bergie commented Jan 10, 2014

Great work @forresto !

I wonder however if the groups could be presented as more complex shapes than just rectangles. Might be interesting if the group would shape itself to "avoid" the non-grouped nodes that it is now overlapping:

screenshot 2014-01-10 at 11 43 17

@forresto
Copy link
Collaborator

I thought about that, but it would be pretty complex and the autolayout algo we're looking at does that first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants