-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Library is not compatible with module loaders. #12
Comments
@Undergrounder do you have any suggestion or you have a possible pull request in mind? :) |
I could prepare a pull request with the tools I'm confortable (webpack) if you agree with this. It would be then compatible with the browser, the amd and CommonJS specifications. |
You are good to go, If you can make it without breaking changes |
Closed in #15 |
thanks @Undergrounder ! so well done! i've left you some comments for some corrections i think we would need before merging the patch. would you please evaluate to refine it? |
The library is using some globals (window.Flow and window.FustyFlow) instead of requiring them and
the FustyFlow class is never imported when using npm require.
This makes using it with webpack and other module bundlers very tricky.
The text was updated successfully, but these errors were encountered: