Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod Manager reads mod name that contains colon as mapping values when importing from string and breaks off #150

Open
Bratwurstinator opened this issue Jun 8, 2021 · 0 comments
Labels
bug Something isn't working unverified

Comments

@Bratwurstinator
Copy link

Bratwurstinator commented Jun 8, 2021

Describe the bug
When a mod name contains a colon ( ':' ), fluffy's mod manager throws an exception pointing towards said colon (see below) and breaks off the importing process. I assume it reads the mod name as a mapping value due to the colon (xml mapping works that way, apparently), which is not allowed.

Expected behavior
That it imports correctly...

Steps to reproduce

  1. Start Rimworld with Fluffy's Mod Manager enabled
  2. Copy a mod list which contains a mod that has a modname with a colon, like for example "Rim-Effect: Core"
  3. Import mod list from string

Example:
Example list:
<?xml version="1.0" encoding="utf-8"?>
<ModList>
<Name>test123
<modIds>
<li>brrainz.harmony
<li>ludeon.rimworld
<li>fluffy.modmanager
<li>erdelf.humanoidalienraces
<li>oskarpotocki.vanillafactionsexpanded.core
<li>rimeffect.core
</modIds>
<modNames>
<li>Harmony
<li>Core
<li>Mod Manager
<li>Humanoid Alien Races 2.0
<li>Vanilla Expanded Framework
<li>Rim-Effect: Core
</modNames>
</ModList>
Error:
"Failed to import mod list from clipboard: (Line: 18, Col: 17, Idx: 468) - (Line: 18, Col: 17, Idx: 468): Mapping Values not allowed in this context."

Other mods
Harmony

Environment

  • OS: Win10
  • 64bits

Game

  • 64 bits
  • Steam
  • Version 1.2.3005
@Bratwurstinator Bratwurstinator added bug Something isn't working unverified labels Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working unverified
Projects
None yet
Development

No branches or pull requests

1 participant