From 2b9dcf945bc4cc3dc726e6b9569935b1b2f8a113 Mon Sep 17 00:00:00 2001 From: Ben Konyi Date: Mon, 2 Dec 2024 16:20:45 -0500 Subject: [PATCH] Temporarily disable `Code` based profiling when VM Developer Mode is enabled (#8578) Works around https://github.com/flutter/devtools/issues/8567 until `package:vm_service` 15.0.0 is rolled through to Flutter. --- .../devtools_app/lib/src/service/vm_service_wrapper.dart | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/devtools_app/lib/src/service/vm_service_wrapper.dart b/packages/devtools_app/lib/src/service/vm_service_wrapper.dart index c8a906f1f8f..3e12a9bfc42 100644 --- a/packages/devtools_app/lib/src/service/vm_service_wrapper.dart +++ b/packages/devtools_app/lib/src/service/vm_service_wrapper.dart @@ -20,7 +20,6 @@ import 'package:vm_service/vm_service.dart'; import '../screens/vm_developer/vm_service_private_extensions.dart'; import '../shared/feature_flags.dart'; -import '../shared/globals.dart'; import '../shared/primitives/utils.dart'; import 'json_to_service_cache.dart'; @@ -143,7 +142,9 @@ class VmServiceWrapper extends VmService { // running with VM developer mode enabled. This data isn't accessible // in non-VM developer mode, so not requesting the code profile will // save on space and network usage. - '_code': preferences.vmDeveloperModeEnabled.value, + // TODO(bkonyi): re-enable when package:vm_service 15.0.0 is rolled + // into Flutter. See https://github.com/flutter/devtools/issues/8567. + // '_code': preferences.vmDeveloperModeEnabled.value, }, ).then((e) => e as CpuSamples); }