You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I believe, LikeButton should use InkResponse instead of GestureDetector inside the code here. The InkResponse can then also use the appropriate HoverColor and HighlightColor.
This can also be seen in Twitters design:
This would also provide changing the Cursor automatically on hover, on Desktop / Web.
To perfectly recreate the Twitter behaviour, a custom InkHighlight and a MouseRegion might be needed, instead of InkResponse.
Furthermore, I believe that if onTap is null, the LikeButton should be disabled.
the Icon and Text inside of the LikeButton should then change its Color to a disabled state.
It would be nice if LikeButton had its own ButtonStyle, with appropriate MaterialStateProperty like other buttons.
This would help to make LikeButton feel more like official Flutter widgets.
The text was updated successfully, but these errors were encountered:
I believe, LikeButton should use
InkResponse
instead ofGestureDetector
inside the code here. TheInkResponse
can then also use the appropriateHoverColor
andHighlightColor
.This can also be seen in Twitters design:
This would also provide changing the Cursor automatically on hover, on Desktop / Web.
To perfectly recreate the Twitter behaviour, a custom
InkHighlight
and aMouseRegion
might be needed, instead ofInkResponse
.Furthermore, I believe that if
onTap
isnull
, the LikeButton should be disabled.the Icon and Text inside of the LikeButton should then change its Color to a disabled state.
It would be nice if LikeButton had its own
ButtonStyle
, with appropriateMaterialStateProperty
like other buttons.This would help to make LikeButton feel more like official Flutter widgets.
The text was updated successfully, but these errors were encountered: