Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'channel' query parameter to "/expressions" query #10

Open
orestesgaolin opened this issue Mar 18, 2020 · 5 comments
Open

Add 'channel' query parameter to "/expressions" query #10

orestesgaolin opened this issue Mar 18, 2020 · 5 comments
Assignees

Comments

@orestesgaolin
Copy link

From what I can see right now we can provide list of channels to filter the expressions.

This needs to be passed as query parameter which is a bit unusual e.g. ?context=id/null & ?channels=[String, ...] & .

I'd like to propose to add another parameter called channel that would accept only single channel.

Reference

@jdeepee
Copy link
Member

jdeepee commented Mar 19, 2020

Are these issues in the right repo or do you mean to post this inside: https://github.com/juntofoundation/Junto-REST-API?

@jdeepee
Copy link
Member

jdeepee commented Mar 19, 2020

In the case you are talking about the REST-API. As of current channel query params are passed like so (the docs are a little incorrect):

?channels[0]=string&channels[1]=string ...

You can pass up to five channels here using this format. If you wish to pass one you can just do:
?channels[0]=string

@orestesgaolin
Copy link
Author

This messes with our code generation for http requests i.e. we can't have property called channels[0] so we have to type this query parameter manually which in turn makes any related automated code generation impossible.

Having ability to set query parameter channel=foo would be very convenient.

BTW sorry, I didn't know it's related to different API.

@jdeepee
Copy link
Member

jdeepee commented Mar 19, 2020

Sure I can do that. How about sending the other channels? How does that best work for you?

@orestesgaolin
Copy link
Author

@sunyatax do we want to support multiple channels filtering?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants