-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to display file sizes and modification dates, and optionally sort by them #165
Comments
Can we use the table demo for that? The metadata will be available with #184. |
We can try. But it won't be that easy and we have to rewrite a lot of code for the central panel. Is there a |
I think it also works with a |
I'm playing around with it, and I think the |
But I think this bug in egui needs to be fixed first, before we can continue here: emilk/egui#5045 |
Ough yes, that doesn't look good. Maybe we can implement a workaround for this. Unfortunately, the issue has been around for 3 months now... |
The main change is that this function /// Returns an iterator in the given range of the directory contents.
/// No filters are applied using this iterator.
pub fn iter_range_mut(
&mut self,
range: std::ops::Range<usize>,
) -> impl Iterator<Item = &mut DirectoryEntry> {
self.content[range].iter_mut()
} will no longer be used and instead everything is handled by indices: /// Returns one directory entry by index
pub fn get(&mut self, i: usize) -> Option<&mut DirectoryEntry> {
self.content.get_mut(i)
}
pub fn filtered_get<'s>(
&'s mut self,
index: usize,
search_value: &'s str,
) -> Option<&'s mut DirectoryEntry> {
self.content
.iter_mut()
.filter(|p| apply_search_value(p, search_value))
.nth(index)
}
pub fn filtered_count(&self, search_value: &str) -> usize {
self.content
.iter()
.filter(|p| apply_search_value(p, search_value))
.count()
} This is due to the implementation of |
These are commonly expected features from a file picker
The text was updated successfully, but these errors were encountered: