fix: don't deny event sequence after zoom #1307
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flxzt
approved these changes
Nov 28, 2024
|
Seems to fix the issue on my machine as well (surface pro 8, on windows). |
|
the two-finger long-press action works for me on main and with this change, but I am testing it on Fedora |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeps the event sequence of zoom gestures claimed if they were not canceled. This prevents the sequences from propagating to other events like the long press gesture. I haven't noticed any unintended side effects.
Would be nice to have some feedback on this before merging it into main, gestures tend to behave very differently in different environments ;)