Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installations and updates are executed despite MSFS open #463

Open
FoxtrotSierra6829 opened this issue Apr 1, 2024 · 8 comments
Open

Installations and updates are executed despite MSFS open #463

FoxtrotSierra6829 opened this issue Apr 1, 2024 · 8 comments
Labels
Bug Something isn't working Critical The issue or PR is critical and needs immediate attention

Comments

@FoxtrotSierra6829
Copy link
Member

FoxtrotSierra6829 commented Apr 1, 2024

Installer Version

v3.4.0

Describe the bug

Updating MSFS addons is not being prevented when MSFS is open, which can lead to file corruption and errors in the VFS.

Expected behavior

All forms of installation and uninstallation conflicting with an external application should be unavailable while the external application is open.

Steps to reproduce

  • have MSFS open
  • update e.g. A32NX
  • update is successfully executed

References (optional)

grafik
grafik

Additional info (optional)

Suspect functionality was compromised in a past refactor.
Appears to be functional up to v3.3.8
grafik

Discord Username (optional)

foxtrotsierra

@FoxtrotSierra6829 FoxtrotSierra6829 added Bug Something isn't working Critical The issue or PR is critical and needs immediate attention labels Apr 1, 2024
@tracernz
Copy link
Member

tracernz commented Apr 1, 2024

Would be good to have an “are you sure?” red warning rather than outright refusing.

@FoxtrotSierra6829
Copy link
Member Author

Would be good to have an “are you sure?” red warning rather than outright refusing.

Tbh, updating and uninstalling should be outright refused while MSFS is open. Installing, okay, it's not gonna destroy anything, the addon is just not going to appear in the current instance.

@tracernz
Copy link
Member

tracernz commented Apr 1, 2024

Restarting a flight will reload most things from disk, and quick reload in the behaviour window reloads everything else from disk, so it’s quite useful for power users to be able to do it.

@FoxtrotSierra6829
Copy link
Member Author

We're frequently discussing with users if removing all other addons except for the A32NX means that there can still be other aircraft, sceneries and liveries in the community folder or not. I don't think we can expect everyone to reload via the dev tools after updating.

@tracernz
Copy link
Member

tracernz commented Apr 1, 2024

Power users are not the ones coming for support.

@FoxtrotSierra6829
Copy link
Member Author

Power users are not the ones coming for support.

Yeah but we don't only build the installer for power users. In that regard, protecting the average end user and lowering the support volume is of higher priority to me. Maybe we can think about an override switch in the developer settings.

@tracernz
Copy link
Member

tracernz commented Apr 2, 2024

MSFS addon linker does exactly what I had in mind, only we could be a little more forceful with colour.
image

@alepouna
Copy link
Member

Both points are valid to be honest. The poweruser will know the risks, but the average Joe might just skip the warning because 'big red button i must press!' which would not be handy for support, though I'm sure by year 4 of MSFS even new users should know you need to restart for things to show up from your community folder.

A timer or a require tickbox (everytime) before you can continue, or a setting in an advanced section of the installer would work both ways I think. Though to be fair, the "powerusers" might build from source, or download directly from GitHub rather than use our installer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Critical The issue or PR is critical and needs immediate attention
Projects
None yet
Development

No branches or pull requests

3 participants