Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Don't commit js files that compiled from ts files #19

Open
finscn opened this issue Jun 4, 2018 · 2 comments
Open

Suggestion: Don't commit js files that compiled from ts files #19

finscn opened this issue Jun 4, 2018 · 2 comments

Comments

@finscn
Copy link
Contributor

finscn commented Jun 4, 2018

the js files compiled from ts files are as same as dist/build files.

In most open source projects , they won't commit dist/build files to git.
And they will tell users how to build/compile the project.

@flyover
Copy link
Owner

flyover commented Jun 4, 2018

Yes, I agree. I plan on addressing this with the multiple-output (systemjs, commonjs, ...) change.

@flyover
Copy link
Owner

flyover commented Nov 25, 2019

I think I'm going to leave them for the time being. It's an easy way to side-by-side the output. It's also easy to hide them in the source tree (in VS Code).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants