Change phase to WaitingForResources when quota exceeded (#5195)

flyteorg · Apr 7, 2024 · 6d58c73 · 6d58c73
1 parent 934f5c1
commit 6d58c73
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/flyteplugins/go/tasks/pluginmachinery/internal/webapi/allocation_token.go b/flyteplugins/go/tasks/pluginmachinery/internal/webapi/allocation_token.go
@@ -64,8 +64,8 @@ func (a tokenAllocator) allocateToken(ctx context.Context, p webapi.AsyncPlugin,
 		return &State{
 				AllocationTokenRequestStartTime: startTime,
 				Phase:                           PhaseNotStarted,
-			}, core.PhaseInfoQueued(
-				a.clock.Now(), 0, "Quota for task has exceeded. The request is enqueued."), nil
+			}, core.PhaseInfoWaitingForResourcesInfo(
+				a.clock.Now(), 0, "Quota for task has exceeded. Waiting for the resource.", nil), nil
 	}
 
 	return nil, core.PhaseInfo{}, fmt.Errorf("allocation status undefined [%v]", allocationStatus)

diff --git a/flytepropeller/pkg/controller/nodes/task/resourcemanager/config/config.go b/flytepropeller/pkg/controller/nodes/task/resourcemanager/config/config.go
@@ -27,7 +27,7 @@ var (
 
 // Configs for Resource Manager
 type Config struct {
-	Type             Type        `json:"type" pflag:"noop,Which resource manager to use"`
+	Type             Type        `json:"type" pflag:"noop, Which resource manager to use, redis or noop. Default is noop."`
 	ResourceMaxQuota int         `json:"resourceMaxQuota" pflag:",Global limit for concurrent Qubole queries"`
 	RedisConfig      RedisConfig `json:"redis" pflag:",Config for Redis resourcemanager."`
 }

diff --git a/flytepropeller/pkg/controller/nodes/task/resourcemanager/config/config_flags.go b/flytepropeller/pkg/controller/nodes/task/resourcemanager/config/config_flags.go