From 8caf7dd6c97dc5778b86206c4265156a921b4319 Mon Sep 17 00:00:00 2001 From: Kevin Su Date: Tue, 19 Sep 2023 14:06:31 -0700 Subject: [PATCH] Bump flytestdlib version (#619) Signed-off-by: Kevin Su --- flytepropeller/go.mod | 4 ++-- flytepropeller/go.sum | 8 ++++---- .../pkg/controller/nodes/subworkflow/launchplan/admin.go | 7 +++++++ 3 files changed, 13 insertions(+), 6 deletions(-) diff --git a/flytepropeller/go.mod b/flytepropeller/go.mod index bf11056127..a5a93af9e1 100644 --- a/flytepropeller/go.mod +++ b/flytepropeller/go.mod @@ -7,8 +7,8 @@ require ( github.com/benlaurie/objecthash v0.0.0-20180202135721-d1e3d6079fc1 github.com/fatih/color v1.13.0 github.com/flyteorg/flyteidl v1.5.13 - github.com/flyteorg/flyteplugins v1.1.23 - github.com/flyteorg/flytestdlib v1.0.22 + github.com/flyteorg/flyteplugins v1.1.28 + github.com/flyteorg/flytestdlib v1.0.24 github.com/ghodss/yaml v1.0.0 github.com/go-redis/redis v6.15.7+incompatible github.com/go-test/deep v1.0.7 diff --git a/flytepropeller/go.sum b/flytepropeller/go.sum index 9d127f7909..013f996513 100644 --- a/flytepropeller/go.sum +++ b/flytepropeller/go.sum @@ -244,10 +244,10 @@ github.com/fatih/color v1.13.0/go.mod h1:kLAiJbzzSOZDVNGyDpeOxJ47H46qBXwg5ILebYF github.com/felixge/httpsnoop v1.0.1/go.mod h1:m8KPJKqk1gH5J9DgRY2ASl2lWCfGKXixSwevea8zH2U= github.com/flyteorg/flyteidl v1.5.13 h1:IQ2Cw+u36ew3BPyRDAcHdzc/GyNEOXOxhKy9jbS4hbo= github.com/flyteorg/flyteidl v1.5.13/go.mod h1:EtE/muM2lHHgBabjYcxqe9TWeJSL0kXwbI0RgVwI4Og= -github.com/flyteorg/flyteplugins v1.1.23 h1:N526EeVHQwdMTiQ25Qa7F4y1izQeqP4rU0+Ogv6M6Kw= -github.com/flyteorg/flyteplugins v1.1.23/go.mod h1:HEd4yf0H8XfxMcHFwrTdTIJ/9lEAz83OpgcFQe47L6I= -github.com/flyteorg/flytestdlib v1.0.22 h1:8RAc+TmME54FInf4+t6+C7X8Z/dW6i6aTs6W8SEzpI8= -github.com/flyteorg/flytestdlib v1.0.22/go.mod h1:6nXa5g00qFIsgdvQ7jKQMJmDniqO0hG6Z5X5olfduqQ= +github.com/flyteorg/flyteplugins v1.1.28 h1:vf0Qzxkh9xezF/DrXIQW92lSnjreGIiBfGyBVmDpBXQ= +github.com/flyteorg/flyteplugins v1.1.28/go.mod h1:FujFQdL/f9r1HvFR81JCiNYusDy9F0lExhyoyMHXXbg= +github.com/flyteorg/flytestdlib v1.0.24 h1:jDvymcjlsTRCwOtxPapro0WZBe3isTz+T3Tiq+mZUuk= +github.com/flyteorg/flytestdlib v1.0.24/go.mod h1:6nXa5g00qFIsgdvQ7jKQMJmDniqO0hG6Z5X5olfduqQ= github.com/flyteorg/stow v0.3.7 h1:Cx7j8/Ux6+toD5hp5fy++927V+yAcAttDeQAlUD/864= github.com/flyteorg/stow v0.3.7/go.mod h1:5dfBitPM004dwaZdoVylVjxFT4GWAgI0ghAndhNUzCo= github.com/form3tech-oss/jwt-go v3.2.2+incompatible/go.mod h1:pbq4aXjuKjdthFRnoDwaVPLA+WlJuPGy+QneDUgJi2k= diff --git a/flytepropeller/pkg/controller/nodes/subworkflow/launchplan/admin.go b/flytepropeller/pkg/controller/nodes/subworkflow/launchplan/admin.go index 574464a1c4..913ae101d7 100644 --- a/flytepropeller/pkg/controller/nodes/subworkflow/launchplan/admin.go +++ b/flytepropeller/pkg/controller/nodes/subworkflow/launchplan/admin.go @@ -47,6 +47,13 @@ type executionCacheItem struct { ExecutionOutputs *core.LiteralMap } +func (e executionCacheItem) IsTerminal() bool { + if e.ExecutionClosure == nil { + return false + } + return e.ExecutionClosure.Phase == core.WorkflowExecution_ABORTED || e.ExecutionClosure.Phase == core.WorkflowExecution_FAILED || e.ExecutionClosure.Phase == core.WorkflowExecution_SUCCEEDED +} + func (e executionCacheItem) ID() string { return e.String() }