From d751d0ba83a5c4596c3fa4d3d7de16478de30058 Mon Sep 17 00:00:00 2001 From: "Ethan Brown (Domino)" <111539728+ddl-ebrown@users.noreply.github.com> Date: Mon, 26 Feb 2024 05:55:05 -0800 Subject: [PATCH] Fix flyte-core rendering when flyteagent enabled (#4922) - Flyte agent now tries to render a specific set of podLabels, so assumes that there is an empty `podLabels: {}` set. This change to values.yaml for flyte-core ensures empty values are there. - Fixes: Error: template: flyte-core/charts/flyteagent/templates/agent/deployment.yaml:17:17: executing "flyte-core/charts/flyteagent/templates/agent/deployment.yaml" at : error calling include: template: flyte-core/templates/_helpers.tpl:122:16: executing "flyteagent.podLabels" at <.Values.flyteagent.podLabels>: nil pointer evaluating interface {}.podLabels Signed-off-by: ddl-ebrown --- charts/flyte-core/README.md | 1 + charts/flyte-core/values.yaml | 2 ++ 2 files changed, 3 insertions(+) diff --git a/charts/flyte-core/README.md b/charts/flyte-core/README.md index 460151fcbb..ea4435945d 100644 --- a/charts/flyte-core/README.md +++ b/charts/flyte-core/README.md @@ -194,6 +194,7 @@ helm install gateway bitnami/contour -n flyte | flyteagent.enabled | bool | `false` | | | flyteagent.plugin_config.plugins.agentService.defaultAgent.endpoint | string | `"dns:///flyteagent.flyte.svc.cluster.local:8000"` | | | flyteagent.plugin_config.plugins.agentService.defaultAgent.insecure | bool | `true` | | +| flyteagent.podLabels | object | `{}` | Labels for flyteagent pods | | flyteconsole.affinity | object | `{}` | affinity for Flyteconsole deployment | | flyteconsole.enabled | bool | `true` | | | flyteconsole.ga.enabled | bool | `false` | | diff --git a/charts/flyte-core/values.yaml b/charts/flyte-core/values.yaml index 109710edef..36e2b87eaa 100755 --- a/charts/flyte-core/values.yaml +++ b/charts/flyte-core/values.yaml @@ -279,6 +279,8 @@ flyteagent: defaultAgent: endpoint: "dns:///flyteagent.flyte.svc.cluster.local:8000" insecure: true + # -- Labels for flyteagent pods + podLabels: {} # # FLYTEPROPELLER SETTINGS