Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Latest FlyteIDL for MonoDoc CI #4694

Conversation

Future-Outlier
Copy link
Member

@Future-Outlier Future-Outlier commented Jan 9, 2024

Problem

Currently, the latest flytekit and the latest flyteidl (beta version) are released.
I want to update the version in monodoc so that some PR used the latest flyteidl can be merged.

Solution

  1. update the dependency in monodocs-environment.yaml
  2. use conda-lock -f monodocs-environment.yaml --lockfile monodocs-environment.lock.yaml to update dependencies.

Signed-off-by: Future Outlier <[email protected]>
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. documentation Improvements or additions to documentation enhancement New feature or request labels Jan 9, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bce5d8c) 59.02% compared to head (f27dd14) 59.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4694   +/-   ##
=======================================
  Coverage   59.02%   59.02%           
=======================================
  Files         643      643           
  Lines       55153    55153           
=======================================
+ Hits        32552    32555    +3     
+ Misses      20020    20018    -2     
+ Partials     2581     2580    -1     
Flag Coverage Δ
unittests 59.02% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Future-Outlier Future-Outlier enabled auto-merge (squash) January 9, 2024 07:16
@Future-Outlier Future-Outlier enabled auto-merge (squash) January 9, 2024 07:16
@Future-Outlier
Copy link
Member Author

@pingsutw Please help merge it, thanks!

@Future-Outlier Future-Outlier marked this pull request as draft January 11, 2024 21:24
@Future-Outlier
Copy link
Member Author

@cosmicBboy if possible, please take a look, thank you very much!

@Future-Outlier Future-Outlier marked this pull request as ready for review January 13, 2024 04:51
@Future-Outlier Future-Outlier marked this pull request as draft January 21, 2024 07:55
@Future-Outlier
Copy link
Member Author

Future-Outlier commented Jan 31, 2024

command I use:

conda-lock -f monodocs-environment.yaml --lockfile monodocs-environment.lock.yaml

error message:

Locking dependencies for ['linux-64', 'osx-arm64']...
INFO:conda_lock.conda_solver:linux-64 using specs ['python 3.9.*', 'pip *', 'codespell', 'furo', 'gitpython', 'ipython !=8.7.0', 'graphviz', 'jupytext', 'myst-nb', 'psycopg2-binary', 'recommonmark', 'sphinx 4.5.0', 'sphinx-prompt', 'sphinx-click', 'sphinx-autoapi', 'sphinx-copybutton', 'sphinx-issues', 'sphinx_fontawesome', 'sphinx-panels', 'sphinxcontrib-mermaid', 'sphinxcontrib-youtube 1.2.0', 'sphinx-tabs', 'sphinx-tags 0.2.1', 'retry', 'botocore', 'fsspec', 'google-cloud-bigquery', 'markdown', 'plotly', 'great-expectations', 'datasets', 'kubernetes', 'modin', 'pandera', 'pydantic', 'papermill', 'jupyter', 'polars', 'pyspark', 'sqlalchemy', 'pytorch', 'skl2onnx', 'numpy 1.23.5', 'tf2onnx', 'tensorflow >=2.13.0', 'scikit-learn', 'dask', 'mlflow 2.7.0', 'snowflake-connector-python', 'vaex-core']

Signed-off-by: Future-Outlier <[email protected]>
@eapolinario
Copy link
Contributor

subsumed by #4815

@eapolinario eapolinario closed this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants