Streaming log for agent #4767
Draft
Streaming log for agent #4767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <[email protected]>
dosubot
bot
added
size:L
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4767 +/- ##
==========================================
- Coverage 58.21% 58.20% -0.01%
==========================================
Files 626 626
Lines 53855 53950 +95
==========================================
+ Hits 31349 31402 +53
- Misses 19996 20038 +42
Partials 2510 2510
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
EngHabu
previously approved these changes
Jan 23, 2024
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
kumare3
previously approved these changes
Jan 23, 2024
andrewwdye
reviewed
Jan 24, 2024
| @@ -23,7 +23,7 @@ service AsyncAgentService { | |||
| rpc GetTaskMetrics(flyteidl.admin.GetTaskMetricsRequest) returns (flyteidl.admin.GetTaskMetricsResponse){}; | |||
|
|
|||
| // GetTaskLogs returns task execution logs, if available. | |||
| rpc GetTaskLogs(flyteidl.admin.GetTaskLogsRequest) returns (flyteidl.admin.GetTaskLogsResponse){}; | |||
| rpc GetTaskLogs(flyteidl.admin.GetTaskLogsRequest) returns (stream flyteidl.admin.GetTaskLogsResponse){}; | |||
There was a problem hiding this comment.
What does the usage pattern look like here? GetTaskLogsResponse contains a list of string results + a page token
Signed-off-by: Kevin Su <[email protected]>
andrewwdye
approved these changes
Jan 24, 2024
|
converted to draft since Hattham has another pr to update the proto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
#3936
Why are the changes needed?
Use streaming response for the
getLogsAPI since users don't want to pull all the logs in the one gRPC call.What changes were proposed in this pull request?
Update response of
GetTaskLogstostream flyteidl.admin.GetTaskLogsResponseCheck all the applicable boxes