Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage KubeRay v1 instead of v1alpha1 for resources #4818

Merged
merged 14 commits into from
Feb 13, 2024

Conversation

peterghaddad
Copy link
Contributor

Tracking issue

#4802

Closes #4802

Why are the changes needed?

The new API version for the Ray Job CRD enables further customization. This will benefit future issues, and will ensure that people are using the latest and greatest API versions. We will still support v1alpha1 and will default to it in the configuration so there are no interruptions to the community.

What changes were proposed in this pull request?

Add config option to choose between using KubeRay CRD versions.
Add KubeRay v1 as an option for creating KubeRay Jobs.

How was this patch tested?

Through unit tests.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Copy link

welcome bot commented Feb 1, 2024

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Feb 1, 2024
Copy link
Contributor

@eapolinario eapolinario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a few tests to ray_test.go?

@peterghaddad
Copy link
Contributor Author

@eapolinario I noticed the build failed due to it "being cancelled". Is this expected? Is there a way to test and ensure everything is good to go through the CI? Thanks!

@eapolinario
Copy link
Contributor

Thanks for adding tests! I just approved the CI checks (they are setup in such a way that maintainers have to manually approve for them to run).

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 119 lines in your changes are missing coverage. Please review.

Comparison is base (4afb743) 59.51% compared to head (61020a8) 58.91%.

Files Patch % Lines
flyteplugins/go/tasks/plugins/k8s/ray/ray.go 38.97% 111 Missing and 8 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4818      +/-   ##
==========================================
- Coverage   59.51%   58.91%   -0.61%     
==========================================
  Files         645      645              
  Lines       51891    55351    +3460     
==========================================
+ Hits        30883    32609    +1726     
- Misses      18435    20159    +1724     
- Partials     2573     2583      +10     
Flag Coverage Δ
unittests 58.91% <38.97%> (-0.87%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterghaddad
Copy link
Contributor Author

peterghaddad commented Feb 6, 2024

@eapolinario can we try triggering these again? Had to push a couple fixes up. Also, let me know if this is ready to go!

@eapolinario
Copy link
Contributor

@peterghaddad , can you merge master (to get rid of the docs error) and sign DCO? The change itself looks good, but we need fix those before merging.

@peterghaddad
Copy link
Contributor Author

@eapolinario signed off and merged master!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 10, 2024
@peterghaddad
Copy link
Contributor Author

@eapolinario no rush, but politely wanted to follow up on this!

@davidmirror-ops davidmirror-ops merged commit d6747c1 into flyteorg:master Feb 13, 2024
46 of 48 checks passed
Copy link

welcome bot commented Feb 13, 2024

Congrats on merging your first pull request! 🎉

katrogan pushed a commit that referenced this pull request Feb 20, 2024
* initial

* Clean up

* init

* Clean up

* Add TestGetEventInfo_LogTemplatesV1

* Add more tests

* Fix tests

* Remove dupe

* Fix lint

* add comment

Signed-off-by: peterghaddad <[email protected]>

---------

Signed-off-by: peterghaddad <[email protected]>
Co-authored-by: Neil <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
yubofredwang pushed a commit to yubofredwang/flyte that referenced this pull request Mar 26, 2024
* initial

* Clean up

* init

* Clean up

* Add TestGetEventInfo_LogTemplatesV1

* Add more tests

* Fix tests

* Remove dupe

* Fix lint

* add comment

Signed-off-by: peterghaddad <[email protected]>

---------

Signed-off-by: peterghaddad <[email protected]>
Co-authored-by: Neil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Have option to use v1 instead of v1alpha1 for Ray Jobs
4 participants