Use ratelimiter config in webapi plugins #5190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ketan Umare <[email protected]>
dosubot
bot
added
size:S
Signed-off-by: Ketan Umare <[email protected]>
EngHabu
previously approved these changes
Apr 5, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5190 +/- ##
==========================================
+ Coverage 59.07% 59.09% +0.01%
==========================================
Files 646 646
Lines 55739 55742 +3
==========================================
+ Hits 32928 32938 +10
+ Misses 20215 20208 -7
Partials 2596 2596
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kumare3
changed the title
Signed-off-by: Ketan Umare <[email protected]>
EngHabu
approved these changes
Apr 5, 2024
pingsutw
approved these changes
Apr 5, 2024
Jeinhaus
pushed a commit
to Jeinhaus/flyte
that referenced
this pull request
Apr 8, 2024
Signed-off-by: Ketan Umare <[email protected]> Co-authored-by: Ketan Umare <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ratelimiter config was not used to configure the rate limiter for webapi plugins.