Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove obsolete flyte config files #5196

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Apr 7, 2024

Tracking issue

NA

Why are the changes needed?

These configs haven't been updated for a while, and it's not necessary to maintain different configs in the Flyte repo.

What changes were proposed in this pull request?

remove obsolete flyte config files

How was this patch tested?

NA

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

NA

Docs link

NA

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. housekeeping Issues that help maintain flyte and keep it tech-debt free labels Apr 7, 2024
Future-Outlier
Future-Outlier previously approved these changes Apr 7, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 7, 2024
kumare3
kumare3 previously approved these changes Apr 8, 2024
@kumare3
Copy link
Contributor

kumare3 commented Apr 8, 2024

Cc @davidmirror-ops

@eapolinario
Copy link
Contributor

eapolinario commented Apr 8, 2024

flyte_local_k3d.yaml is still referenced in https://github.com/flyteorg/flyte/blob/master/script/setup_local_dev.sh#L173 (which I know that at least Dan uses). That said, it should be pretty easy to move this to dev mode.

@davidmirror-ops
Copy link
Contributor

davidmirror-ops commented Apr 10, 2024

I confirmed with Dan that all these files can be safely removed.
flytectl start --dev is the way to go :)

Having said so, should we also remove setup_local_dev.sh ?

hamersaw
hamersaw previously approved these changes Apr 10, 2024
Signed-off-by: Kevin Su <[email protected]>
@pingsutw pingsutw dismissed stale reviews from hamersaw, kumare3, and Future-Outlier via 903b7dc April 10, 2024 20:32
@davidmirror-ops davidmirror-ops merged commit dd67ff0 into master Apr 10, 2024
46 checks passed
@davidmirror-ops davidmirror-ops deleted the remove-config branch April 10, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants