perf(cache): Use AddRateLimited for batch enqueue #5228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
kumare3
previously approved these changes
Apr 12, 2024
Signed-off-by: Kevin Su <[email protected]>
dosubot
bot
added
size:S
Signed-off-by: Kevin Su <[email protected]>
wild-endeavor
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
https://flyte-org.slack.com/archives/C05BN3A92SE/p1712926168291449
closed #5202
Why are the changes needed?
workqueue.Addwill add all the item in the async cache to the queue at the same time and cause propeller to send N (number of items in the async cache) requests to the external system and some tasks may run into rate limit issue.What changes were proposed in this pull request?
Use
workqueue.AddRateLimitedinstead ofworkqueue.Add.How was this patch tested?
Local Sandbox
Setup process
Screenshots
NA
Related PRs
NA
Docs link
NA