Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making SigmetBetweenLatOrLon regex stricter #158

Open
kasarit opened this issue Sep 26, 2023 · 0 comments
Open

Consider making SigmetBetweenLatOrLon regex stricter #158

kasarit opened this issue Sep 26, 2023 · 0 comments
Labels
sigmet/airmet SIGMET/AIRMET issues

Comments

@kasarit
Copy link
Contributor

kasarit commented Sep 26, 2023

private static String re1="((N|S)\\sOF\\s([NS]\\d{2,4})\\sAND\\s(N|S)\\sOF\\s([NS](\\d{2,4})))";
private static String re2="((W|E)\\sOF\\s([WE]\\d{3,5})\\sAND\\s(W|E)\\sOF\\s([WE](\\d{3,5})))";

Should the number of digits be stricter (2/3 + optional 2)? See #154 for rationale.

Also make the regex strings private static final and fix the naming.

@kasarit kasarit added the sigmet/airmet SIGMET/AIRMET issues label Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sigmet/airmet SIGMET/AIRMET issues
Projects
None yet
Development

No branches or pull requests

1 participant