Merge pull request CIRC-2184 disable floating collections by default #1534
+151
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CIRC-2205: Remove redundant permission set declarations
- Jenkins's build of previous commit aborted in Github flow due to timeout in api.loans.CheckOutByBarcodeTests.
so that it's available for testing in snapshot etc
…fault' into CIRC-2184-disable-floating-by-default
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CIRC-2184 Disable floating collections by default
Purpose
Disable floating collections by default in order to prevent circulation administrators from inadvertently applying it. For details about the float feature itself, see UXPROD-816.
Approach
The feature must now be enabled by a boolean environment variable ("ENABLE_FLOATING_COLLECTIONS"). The environment variable is checked by the check-in-by-bar-code process, which will skip any floating related functionality if the variable is unset or set to something else than true.
The module's existing "Environment" class is modified to support mocking of environment variables (which are otherwise read-only), in order to be able to test the enabling/disabling of the feature in unit tests.