Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STRIPES-900] Remove explicit typescript version #39

Merged
merged 4 commits into from
Jan 3, 2024
Merged

Conversation

ncovercash
Copy link
Member

@ncovercash ncovercash commented Dec 21, 2023

As part of Jira STRIPES-900, all modules should use one typescript version, inherited from @folio/stripes-webpack. Therefore, the explicit typescript version in this package.json should be removed.

Although we don't directly require @folio/stripes-webpack, @folio/eslint-config-stripes does, and so we get it transitively.

Copy link

github-actions bot commented Dec 21, 2023

Jest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 35d9350. ± Comparison against base commit 6efb120.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 21, 2023

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 35d9350. ± Comparison against base commit 6efb120.

♻️ This comment has been updated with latest results.

Copy link

sonarqubecloud bot commented Jan 3, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ncovercash ncovercash merged commit d056c03 into master Jan 3, 2024
6 checks passed
@zburke zburke deleted the stripes-900 branch March 25, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants