Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot resolve "iconv-lite" from ".../node_modules/restructure/src/DecodeStream.js" and externals are not allowed! #1569

Closed
MickL opened this issue Dec 6, 2024 · 2 comments
Closed

Cannot resolve "iconv-lite" from ".../node_modules/restructure/src/DecodeStream.js" and externals are not allowed! #1569

MickL opened this issue Dec 6, 2024 · 2 comments

Comments

@MickL
Copy link

MickL commented Dec 6, 2024

Bug Report

When building in a Vite project (uses Rollup) it throws the error:

[12:45:41 AM] ERROR Cannot resolve "iconv-lite" from ".../node_modules/restructure/src/DecodeStream.js" and externals are not allowed!

When I see correctly then fontkit was using iconv-lite but it has been removed in 2.0 but 2.0 hasnt yet been added to fontkit, PR #1367

Your environment

  • pdfkit version: 0.15.1
  • Node version: 22.11.0
  • Operating System: macOS
@liborm85
Copy link
Collaborator

pdfkit using fontkit 1.9, where is iconv-lite required. Allow iconv-lite in rollup/vite as external package.
PR for upgrade fontkit is here: #1367

@MickL
Copy link
Author

MickL commented Dec 14, 2024

There PR is open for 2.5 years

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@liborm85 @MickL