Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Make it so music doesn't pre assign on new scenes #19

Open
davidrenne opened this issue Jun 6, 2022 · 1 comment
Open

[Feature] Make it so music doesn't pre assign on new scenes #19

davidrenne opened this issue Jun 6, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@davidrenne
Copy link

Everyone removes imaginopolis song and others on each scene. This was a mistake in the design I believe. Maybe someone can fix that.

@frank-weindel frank-weindel added the enhancement New feature or request label Dec 7, 2022
@willbr
Copy link

willbr commented Aug 5, 2023

There's a struct called BDS for Background Default Sound

3DMMForever/inc/bkgd.h

Lines 84 to 91 in 79b3010

struct BDS
{
short bo;
short osk;
long vlm;
bool fLoop;
TAG tagSnd;
};

Maybe we can edit the background file BKGDS.3cn?

If I edit the BDS quad ID=11 and set the bds.tagSnd.sid field to -1, it's removed from the black background scene.

Or we could patch it out here?

// Add the default sound for the new background, if any
_pbkgd->GetDefaultSound(&tag, &vlm, &fLoop);
if (tag.sid != ksidInvalid) // new background sound
{
// Note: since FSetBkgdCore is only called at edit time,
// it's okay to call FCacheTag. The background default
// sound is not an intrinsic part of the BKGD...it's more
// of a "serving suggestion" that the user can remove
// once the background is added.
Assert(!_pmvie->FPlaying(), "Shouldn't cache tags if movie is playing!");
if (vptagm->FCacheTagToHD(&tag))
{
pmsnd = (PMSND)vptagm->PbacoFetch(&tag, MSND::FReadMsnd);
if (pvNil != pmsnd)
{
sty = pmsnd->Sty();
ReleasePpo(&pmsnd);
// non-destructive if we fail
FAddSndCore(fLoop, fFalse, vlm, sty, 1, &tag);
}
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants