[Feature] Object Grouping 🏘

[davidrenne]

This is the single most powerful feature. CTRL+CLICK to select multiple objects and group together so you can move them frame by frame.

Either clicking something from the animation window or the sidebar with ctrl+click will select all and we have a group button show up and they animate. Finally will I not have to move things frame by frame with multiple objects.

[willbr]

It looks like it's designed around selecting single items.

3DMMForever/inc/scene.h

Lines 147 to 148 in 79b3010

	PACTR _pactrSelected; // Currently selected actor, if any
	PTBOX _ptboxSelected; // Currently selected tbox, if any

[willbr]

We could replace _pactrSelected with a new PGL of selected actors.

3DMMForever/inc/scene.h

Lines 141 to 142 in 79b3010

	PGL _pglpactr; // List of actors in the scene.
	PGL _pglptbox; // List of text boxes in the scene.

[willbr]

fcustCmd is used to track the state of the Ctrl key

3DMMForever/kauai/src/framedef.h

Lines 70 to 74 in 79b3010

	#define fcustNil 0
	#define fcustCmd 1
	#define fcustShift 2
	#define fcustOption 4
	#define kgrfcustKeys 7

Here's an example:

3DMMForever/src/studio/stdioscb.cpp

Lines 201 to 212 in 79b3010

	if ((pcmd->rglw[0] == chttFButtonFW) || (pcmd->rglw[0] == chttFButtonRW))
	{
	_fBtnAddsFrames = ((pcmd->rglw[1] & fcustCmd) &&
	(((pscen->NfrmLast() == pscen->Nfrm()) && (pcmd->rglw[0] == chttFButtonFW)) ||
	((pscen->NfrmFirst() == pscen->Nfrm()) && (pcmd->rglw[0] == chttFButtonRW))));
	StartNoAutoadjust();
	}
	if (!_fBtnAddsFrames)
	{
	return fTrue;
	}

[willbr]

Here's where the mouse drag handler queries the selected actor.

3DMMForever/src/engine/movie.cpp

Line 7298 in 79b3010

pactr = pscen->PactrSelected();

[willbr]

Here's a quick proof of concept.

https://youtu.be/N_sE9byNVao

willbr@1c717e0

[davidrenne]

@willbr you are a god

[frank-weindel]

That is so cool @willbr! Very clear analysis and it's really neat to see.

[davidrenne]

@frank-weindel is there a new repo that features like this can start to be integrated into builds. I'm just confused how foone wants to keep forever building and stable here in this repo but eventually have new builds with things like this. This is the first feature I've ever seen implemented based on animator feedback on github so I'm just not sure how all the maintainers are going to be compiling features for cool stuff like this.

[frank-weindel]

@davidrenne So I think a feature like this remains in scope for 3DMMForever as long as it doesn't break any backwards compatibility with movies/etc. It not requiring UI changes also helps.

[willbr]

We'd have to be careful with the hotkeys.

Ctrl & Shift are both used for dragging, so we don't want to break those.

[willbr]

It's working well so far.

https://youtu.be/j19fIvL7NDc
https://github.com/willbr/3DMMForever/commits/group-test

It now uses a real list.

And, I've added a selection toggle, and Ctrl+A for select all actors.