Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publications in trial #46

Open
netbofia opened this issue Jul 3, 2019 · 2 comments
Open

Publications in trial #46

netbofia opened this issue Jul 3, 2019 · 2 comments
Assignees
Labels

Comments

@netbofia
Copy link
Member

netbofia commented Jul 3, 2019

How do I store this information? The first though was study additionalInfo, but this might warrant a dedicated table for this information.

        "publications": [ 
            {
                "publicationPUI": "doi:10.15454/312953986E3",
                "publicationReference": "https://brapi.org"
            }
        ],

I don't have a method to extract a specific key value pair. From a table with dynamic attributes. But this can be implemented.

@DanFaria
Copy link
Collaborator

Publications were indeed listed under "additionalInfo" in call GetTrials, but since in the call GetTrialsByDbId there is now a dedicated section for them and they have multiple attributes, we should indeed revise our database structure.

Solution: Create a table Publication with the necessary fields plus the trialId (I think it is safe to assume that each publication can only refer to one trial, so we can link them in this manner).

Action: Create an Issue in the main BrAPI github to ask them to review the GetTrials call so that publications are listed in the same manner in both GetTrials and GetTrialByDbId. It does not make sense to have two different paradigms. In the meanwhile (and if they don't agree with this assessment) we will have to revise the GetTrials call to get the publications from the new Publication table, and list them under additionalInfo.

@netbofia
Copy link
Member Author

The issue has been submitted. Trial Publications inconsistency #382

Will follow up on the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants