Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVGElement.offsetParent is deprecated #225

Open
drosen0 opened this issue Jan 24, 2016 · 1 comment
Open

SVGElement.offsetParent is deprecated #225

drosen0 opened this issue Jan 24, 2016 · 1 comment

Comments

@drosen0
Copy link
Contributor

drosen0 commented Jan 24, 2016

In Chrome 48, when using the tooltip() visualization, this warning is logged to the console:

'SVGElement.offsetParent' is deprecated and will be removed in M50, around April 2016. See https://www.chromestatus.com/features/5724912467574784 for more details.

In contour-utils.js: _.nw.getCentroid(), an assumption is made in the case where offsetParent is falsy, with a comment explaining that Firefox doesn't support offsetParent. It's also referenced in _.nw.getStyle()

Now that it's no longer supported in Chrome either, we need to ensure that the assumption is still valid and remove or replace the code referencing offsetParent.

@drosen0
Copy link
Contributor Author

drosen0 commented Mar 13, 2016

Chrome 50 beta has been released. At first glance, normal tooltips do not appear have any rendering issues. I have not yet done thorough testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant