Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StartTime property not working #491

Open
cv65kr opened this issue Jun 13, 2024 · 0 comments
Open

StartTime property not working #491

cv65kr opened this issue Jun 13, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@cv65kr
Copy link

cv65kr commented Jun 13, 2024

Describe the bug
According to openapi schema https://github.com/formancehq/ledger/blob/main/openapi/v1.yaml#L516

We should use startTime but in code https://github.com/formancehq/ledger/blob/main/internal/api/v1/controllers_transactions.go#L59 is not supported.

Another thing is

if startTime := r.URL.Query().Get("start_time"); startTime != "" {
		clauses = append(clauses, query.Gte("date", startTime))
	}

Column date not exists

To Reproduce
Make request to transaction with time frames

Expected behavior
Transactions are filtered

Environment (please complete the following information):
Main master of ledger

@cv65kr cv65kr added the bug Something isn't working label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant