Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-8626: Updated conditionally hidden logic #121

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

roma-formio
Copy link
Contributor

@roma-formio roma-formio commented Jul 22, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8626

Description

@formio/vm relies on conditionally hidden components to render the email correctly. Previously, we tracked only conditionals that come from logic and set the hidden property to true. However, we also need to handle the opposite operation, where a component is hidden but logic sets the hidden property to false.

How has this PR been tested?

Unit tests

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@johnformio johnformio merged commit 7cf9884 into master Jul 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants