Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO 7603 Edit Grid With Empty Rows Not Submitting Form #5496

Merged

Conversation

Dmeeks512
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-7603

Description

Added check for openWhenEmpty on submission to allow empty rows.

Why have you chosen this solution?

Previous code did not allow form submission on empty rows even when openWhenEmpty flag is enabled.

Breaking Changes / Backwards Compatibility

None

Dependencies

None

How has this PR been tested?

Tested manually and with unit tests.

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

src/components/editgrid/EditGrid.js Outdated Show resolved Hide resolved
@TanyaGashtold TanyaGashtold merged commit 2cbbfe0 into master Feb 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants