Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-7808: fixed an issue where conditional editGrid loses the value after submission #5511

Merged

Conversation

TanyaGashtold
Copy link
Contributor

@TanyaGashtold TanyaGashtold commented Feb 12, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-7808

Description

What changed?

When the validator is run on the server side, the server option is passed for the form and the setValue is called.
When the server option is passed, the clearOnHide method unsets the components values once the conditions check defines that the component is not conditionally visible. The setValue method of editGrid can potentially trigger the conditions check 4 times and it can appear that the values are unset for the editGrid before the other form values are set and the conditions check on the form level is triggered . This PR allows only the conditions check that comes from the form level for the hidden editGrid with server option.

Why have you chosen this solution?

Since this kind of issue is reported for editGrid component only and related to its server behavior, i was trying to make my changes closely specific to editGrid and server option, not to break other components and use cases.

How has this PR been tested?

Formiojs and formio-server tests with those changes are passed for me locally.
I have added automated tests for all use cases where I was able to see the similar issue.

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@HannaKurban HannaKurban merged commit b3a9a82 into master Feb 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants