Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defaultProps deprecation warning #523

Open
PatrikTrefil opened this issue Jul 25, 2023 · 5 comments
Open

defaultProps deprecation warning #523

PatrikTrefil opened this issue Jul 25, 2023 · 5 comments

Comments

@PatrikTrefil
Copy link

Many components in this library use defaultProps, which causes a warning in newer versions of React. It is expected to replaced with JavaScript default parameters instead. (Detailed explanation)

(Example in source code](https://github.com/formio/react/blob/c966dd1d93d1ee5b5610496e2578ebc9ce153eb6/src/components/FormEdit.jsx#L164C13-L164C13)
@brendanbond
Copy link
Contributor

I agree, and PRs are welcome!

@snehaljos
Copy link

Can i work on this issue?

@PatrikTrefil
Copy link
Author

That would be great @snehaljos!

@lokeshshinde08
Copy link

is this issue still open ? if yes I would like to contribute.

@brendanbond
Copy link
Contributor

hi @lokeshshinde08 I'm currently in the process of migrating our React components to TypeScript (done w/ Form, now onto FormBuilder and FormEdit cc: @PatrikTrefil) but thank you for the offer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@brendanbond @snehaljos @PatrikTrefil @lokeshshinde08