Skip to content
This repository has been archived by the owner on Apr 30, 2018. It is now read-only.

Multi-checkbox code bug #35

Closed
kentcdodds opened this issue Jul 8, 2015 · 2 comments
Closed

Multi-checkbox code bug #35

kentcdodds opened this issue Jul 8, 2015 · 2 comments
Labels
bug

Comments

@kentcdodds
Copy link
Member

This line reads:

if(opts.expressionProperties && opts.expressionProperties.required){

This will never evaluate to true because required is an invalid property for the root of the form config. It should read:

if(opts.expressionProperties && opts.expressionProperties['templateOptions.required']){

Sanity check? @ckniffen
@kentcdodds kentcdodds added the bug label Jul 8, 2015
@ckniffen
Copy link
Member

ckniffen commented Jul 8, 2015

Very sane. Great catch.

kentcdodds pushed a commit that referenced this issue Jul 8, 2015
Fixes #35
46abdb9
@kentcdodds
Copy link
Member Author

Released as 4.4.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ckniffen @kentcdodds