Clippy fix1 #369
Open
Clippy fix1 #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 20 commits
September 17, 2024 15:38
mbedtls wrapper macros clippy fix
Benchmark for 0f9f2cbClick to view benchmark
|
Benchmark for 0b32f1dClick to view benchmark
|
Taowyoo
reviewed
Sep 17, 2024
| // Stable-Rust equivalent of `#[non_exhaustive]` attribute. This | ||
| // value should never be used by users of this crate! | ||
| #[doc(hidden)] | ||
| __Nonexhaustive, |
There was a problem hiding this comment.
forget to add #[non_exhaustive] at line 34?
| @@ -558,7 +570,8 @@ impl HandshakeContext { | |||
| } | |||
|
|
|||
| pub fn set_authmode(&mut self, am: AuthMode) -> Result<()> { | |||
| if self.inner.handshake as *const _ == ::core::ptr::null() { | |||
| if self.inner.handshake.is_null() { | |||
| //if self.inner.handshake as *const _ == ::core::ptr::null() { | |||
There was a problem hiding this comment.
forget to clean up commented code ?
line 574 & 585 & 610
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.