Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce duplication of code in provider_api.rs #532

Open
vn971 opened this issue Oct 12, 2023 · 0 comments
Open

Reduce duplication of code in provider_api.rs #532

vn971 opened this issue Oct 12, 2023 · 0 comments

Comments

@vn971
Copy link

vn971 commented Oct 12, 2023

Currently, the code in rust-lang/sys/sgx/abi/usercalls/mod.rs and in rust-sgx/intel-sgx/async-usercalls/src/provider_api.rs (#515) is almost identical for functions copy_user_buffer and string_from_bytebuffer.
After the above PR gets merged, we may be interested in using the new code from inside the Rust standard library (official rust-lang repository). Note that simply making the function public may not be desirable because the code can be considered internal to the SGX platform. This decision is up for the person to pick up this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant