Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup a CI #16

Closed
certik opened this issue Feb 2, 2022 · 3 comments · Fixed by #20
Closed

Setup a CI #16

certik opened this issue Feb 2, 2022 · 3 comments · Fixed by #20
Labels
CI

Comments

@certik
Copy link
Member

certik commented Feb 2, 2022

Using GitHub actions, on Linux, macOS and Windows.
@jacobwilliams
Copy link
Member

note: the existing one is still there, can be upgraded.

Looks like it did run when you merged in #12. But it didn't run ahead of time? Is there some setting for that? I don't fully understand GitHub's logic for when it runs the CI if I'm not the owner of a project.

@awvwgk
Copy link
Member

awvwgk commented Feb 2, 2022

You set the CI up to run only on push:

minpack/.github/workflows/CI.yml

Line 2 in 0c75850

on: [push]

You need to add the respective event to also run it for PRs.

@jacobwilliams
Copy link
Member

Ah!!

@awvwgk awvwgk mentioned this issue Feb 2, 2022
Merged
@certik certik closed this as completed in #20 Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update CI to run on MacOS and Windows awvwgk/minpack
3 participants
@certik @jacobwilliams @awvwgk