Fixing the terms and privacy (container alignment)(for small screen)(indentation) #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #1453 +/- ##
===========================================
Coverage 63.1% 63.1%
===========================================
Files 51 51
Lines 1450 1450
Branches 181 181
===========================================
Hits 915 915
Misses 425 425
Partials 110 110
Continue to review full report at Codecov.
|
|
@praveenojha33 @shreyanshdwivedi @rajvaibhavdubey @AakashMallik please review this |
|
@shreyanshdwivedi please help why travis is showing error for closing tag saying that it is already closed ..... |
subhahu123
changed the title
Pipe-Runner
reviewed
Feb 4, 2019
subhahu123
changed the title
|
@praveenojha33 please review |
sakshee-19
reviewed
Feb 19, 2019
@sakshee-19 please open them (by click) |
@praveenojha33 done |
|
Please rebase. |
…into fossasia-development
Fixed clear search issue fossasia#1230 Fixed double quotes to single quotes Fixed reference for navbar html Fixed spacing issues in constructor scope Fixed clear search issue fossasia#1230 Add Flex Slider to Help Videos (fossasia#1234) Switch Lint (fossasia#1207)Added link to map address Analytics border lie inside the window (fossasia#1346) Refactors Theme Component and added tests for coverage Fixed Contact Form UI (fossasia#1257) Fix 1179 - Add SUSI.AI for Magic Mirror, Yaydoc, Meilix and Phimp.me in Projects section under the menus icon in the navbar Fixed UI of Advanced Search Page add a share button to infobox add a share button to infobox fix indentation add modal add icons fix linting errors fix icons fix travis build errors fix whitespace fix whitespace format HTML add borders improve styles increase padding Style and link fixes on the Privacy and Terms page(fossasia#1261) Tests Added (fossasia#1278) * Tests Added Some of the tests for the files have been added * Tests Added Some of the tests for the newly added functions have been added Fixes fossasia#1327: Contact componnet refactored (fossasia#1328) Fixes fossasia#1267: Infobox share modal, styling fixes, redundancies removed fix footer fixing (fossasia#1351) Update contact.component.ts Update contact.component.html Fixed validations in Contact form Fixed linting issue Added share link and made styles changes to infobox-share-popup (fossasia#1349) Fixes fossasia#1317: Reducers and Actions cleaned (fossasia#1318) Fixed formatting of code Fixed a typo in the contact form Refactored Help Component and Added tests for increasing coverage New Design of about component The design of the about component has been changed Fixes fossasia#1221 Susper logo Addition cursor chnages to hover Update README.md Fixed minor link and ui issues depth field only accepts numbers Loading animation added to result component (fossasia#1204) Fixes fossasia#1308: Refactor app.modules.ts (fossasia#1309) Fixing the susper logo alignment and its container Fixing alignment for all screen sizes Fixing width of div Update index.component.html Update index.component.css Update index.component.html Update index.component.css Update index.component.css Update index.component.css Update index.component.css Fixse fossasia#1306: Removed redundant package delarations (fossasia#1307) Fixing About page css (fossasia#1298) Added sidebar menu on Terms page and tests to increase coverage Fixing the hovering and visited color of links (fossasia#1293) * Changing color of hovering , Visited link Ignoring the overriden of tags of hover and visited * Changing color Fix 1268 - Fix overlapping Help Section with footer (fossasia#1271) * Updated Badgeyay's icon (fossasia#1203) The badgeyay's icon on susper.com has been updated. Fixes fossasia#1201 * "Commit " Added sidebar for Privacy page and tests to increase coverage Fixes fossasia#1242 corrections in crawl job page (fossasia#1243) Fixes fossasia#1310: Travis issue fixed Fix fossasia#1388 : did you mean content is now clickable Added/Updated tests Fixes fossasia#1322: About component refactored and cleaned up Adding rel="noopener" for fixing cross-link links Update dropdown.css To hide overflow along x-axis in the dropdown to give UI effect similar to that of Google Search Update about.component.html Update about.component.html Update about.component.html Update about.component.html Update about.component.html Update about.component.html Update about.component.html Update about.component.html Update about.component.html Update about.component.html Update about.component.html Adding a lang attribute to the html element refactored type changed Search bar is fixed when scrolled Removed fixed navbar for mobile Changed shape of search-bar to curve shape (fossasia#1462) * Changed shape of search-bar to curve shape * Improved the corner of search-bar Merge branch 'development' of https://github.com/fossasia/susper.com into fossasia-development Merge branch 'fossasia-development' into development Conflicts:
…into development
fixing the terms section alignment Indenting and organizing the code indentation of code Update terms.component.html
|
@subhahu123 It makes very difficult for us to review PRs with no proper description, un-squashed commits, could you create a separate PR and fix everything. I am closing this one for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1466
Checklist
masterbranch.Changes proposed in this pull request:
Before
After
