Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(db): fix DB schema types #21

Merged
merged 1 commit into from
Dec 12, 2023
Merged

fix(db): fix DB schema types #21

merged 1 commit into from
Dec 12, 2023

Conversation

GMishx
Copy link
Member

@GMishx GMishx commented Dec 5, 2023

  1. Update LicenseDB type to match the FOSSology DB Schema.
  2. Update the gorm where queries to use struct making future code refactoring easy.
  3. Made typo corrections and better code comments.

Copy link
Member

@avinal avinal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me at first glance, will test by this weekend.

1. Update LicenseDB type to match the FOSSology DB
Schema.
2. Update the gorm where queries to use struct
making future code refactoring easy.
3. Made typo corrections and better code comments.

Signed-off-by: Gaurav Mishra <[email protected]>
Copy link
Contributor

@ag4ums ag4ums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ag4ums ag4ums merged commit 12270f3 into main Dec 12, 2023
2 checks passed
@ag4ums ag4ums deleted the fix/db/schema branch December 12, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants