-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Category field added in obligation (get, post, patch) #84
base: main
Are you sure you want to change the base?
Category field added in obligation (get, post, patch) #84
Conversation
8fac33c
to
8a73421
Compare
@bhowmik94 you need to commit the updated doc files after the |
8a73421
to
f63fa1e
Compare
@bhowmik94 make sure to update the PR description when you are creating one. |
Tried adding curl -X 'PATCH' \
'http://localhost:8085/api/v1/obligations/my%20obligation' \
-H 'accept: application/json' \
-H 'Authorization: my.token' \
-H 'Content-Type: application/json' \
-d '{
"category": "Distribute"
}' The response is 200 {
"status": 200,
"data": [
{
"id": 1,
"topic": "",
"type": "",
"text": "",
"classification": "",
"modifications": false,
"comment": "",
"active": false,
"text_updatable": false,
"category": ""
}
],
"paginationmeta": {
"resource_count": 1
}
} |
@GMishx Kindly try the update request now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the category
value against the allowed values from the enums:"Distribution,Patent,Internal,Contractual,Export Control,General"
. Currently I can put any values in the field with a PATCH
or a POST
request.
Also, the export and import endpoints do not reflect this new field. Please fix it as well.
And please update the PR description!
65d5aaf
to
d41efe9
Compare
848453f
to
0f2da9e
Compare
Signed-off-by: deo002 <[email protected]> refactor(obligations): Make separate database tables for classification and type chore(deps): bump github.com/golang-jwt/jwt/v4 in the go_modules group Bumps the go_modules group with 1 update: [github.com/golang-jwt/jwt/v4](https://github.com/golang-jwt/jwt). Updates `github.com/golang-jwt/jwt/v4` from 4.5.0 to 4.5.1 - [Release notes](https://github.com/golang-jwt/jwt/releases) - [Changelog](https://github.com/golang-jwt/jwt/blob/main/VERSION_HISTORY.md) - [Commits](golang-jwt/jwt@v4.5.0...v4.5.1) --- updated-dependencies: - dependency-name: github.com/golang-jwt/jwt/v4 dependency-type: direct:production dependency-group: go_modules ... Signed-off-by: dependabot[bot] <[email protected]> feat(obligation): category field added in obligation get, post, patch fix: obligation POST, PATCH fixed for category fix: resolve merge conflict feat: added staged changes for category
0f2da9e
to
83ed38e
Compare
Changes
Add category field for obligation GET, POST, PATCH requests
Add category for obligation import & export requests
Validate the field values for the given enum types.
Fixes New field "Category" in obligations GET, PUT, POST #85
Submitter Checklist
References